Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preference of "official servers" #51

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Remove preference of "official servers" #51

merged 1 commit into from
Nov 17, 2023

Conversation

Brutus5000
Copy link
Member

All servers the client passes to the ICE adapter are to be used. Especially with Xirsys added to the pool.

Sheikah45
Sheikah45 reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also remove the selection of only the closest if no coturn has acceptable latency. We should probably just use all in that case I would think.

@Brutus5000
Remove preference of "official servers" & remove fallback for "closes…
8601a32 
…t" servers

All servers the client passes to the ICE adapter are to be used.
Especially with Xirsys added to the pool.
@Brutus5000 Brutus5000 force-pushed the feature/remove-official-coturn-preference branch from 7829ced to 8601a32 Compare November 17, 2023 15:22
@Brutus5000 Brutus5000 merged commit 42a6ac6 into master Nov 17, 2023
1 check passed
@Brutus5000 Brutus5000 deleted the feature/remove-official-coturn-preference branch June 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikah45 Sheikah45 Sheikah45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brutus5000 @Sheikah45